Ticket #205 (closed enhancement: fixed)

Opened 2 years ago

Last modified 1 week ago

Add support for Haskell

Reported by: robin@ohloh.net Assigned to: tux_rocker
Priority: like Milestone: current
Component: parser Version: current
Severity: bad Keywords:
Cc:

Attachments

0001-Added-Haskell-support.patch (8.4 kB) - added by tux_rocker on 01/19/2008 06:10:00 AM.
Patch for support of the Haskell programming language in ohcount
0002-Haskell-support.-Includes-non-new-files.patch (10.9 kB) - added by tux_rocker on 01/19/2008 03:08:54 PM.
0001-Haskell-support-take-two.patch (13.4 kB) - added by tux_rocker on 01/27/2008 09:26:30 AM.
New patch against a fresh checkout

Change History

01/19/2008 06:10:00 AM changed by tux_rocker

  • attachment 0001-Added-Haskell-support.patch added.

Patch for support of the Haskell programming language in ohcount

01/19/2008 03:08:54 PM changed by tux_rocker

  • attachment 0002-Haskell-support.-Includes-non-new-files.patch added.

01/19/2008 03:10:12 PM changed by tux_rocker

Added a second patch that also needs to be applied. The first one only adds files, but makes no changes to existing ones. Blame my inexperience with git.

01/25/2008 11:07:26 AM changed by robin@ohloh.net

  • owner changed from robin@ohloh.net to tux_rocker.

Hi tux_rocker,

I'm sorry to say I'm having some trouble applying the second patch. The first patch goes in OK. I'm something of a newbie with git patching, so I might just not understand what is happening, but it looks like the second patch is partially redundant with the first. This is what happens when I attempt to apply the patches (note also my forced stripping of trailing whitespace here):

~/projects/ohcount$ git checkout -b patch f879617036bdd5fd3a3b025152f58886e88b559a
Switched to a new branch "patch"

~/projects/ohcount$ git am --whitespace=strip ~/Downloads/0001-Added-Haskell-support.patch 

Applying Added Haskell support

Adds trailing whitespace.
.dotest/patch:98:{-| 
Adds trailing whitespace.
.dotest/patch:157:ipBytesToString (b1, b2, b3, b4) = 
Adds trailing whitespace.
.dotest/patch:160:{-| 
Adds trailing whitespace.
.dotest/patch:213:                
warning: 4 lines applied after fixing whitespace errors.
Wrote tree aebed2b56a642f003c50e8bd01563e3001108c5d
Committed: 086b4e5b517bae56822cf4ad9c50c25a24334dce
~/projects/ohcount$ git am --whitespace=strip ~/Downloads/0002-Haskell-support.-Includes-non-new-files.patch 

Applying Haskell support. Includes non-new files.

Adds trailing whitespace.
.dotest/patch:23:                        haskell = CMonoglot.new("haskell",         '--',             [e('{-'), e('-}')], true, false)  
Adds trailing whitespace.
.dotest/patch:157:ipBytesToString (b1, b2, b3, b4) = 
Adds trailing whitespace.
.dotest/patch:183:{-| 
Adds trailing whitespace.
.dotest/patch:203:{-| 
error: patch failed: test/src_dir/haskell2.hs:1
error: test/src_dir/haskell2.hs: patch does not apply
Patch failed at 0001.
When you have resolved this problem run "git-am --resolved".
If you would prefer to skip this patch, instead run "git-am --skip".
~/projects/ohcount$ git apply ~/Downloads/0002-Haskell-support.-Includes-non-new-files.patch 

I tried various sorts of manual trickery, but I couldn't get it to apply.

I feel your pain with Git, sometimes I get horribly tied up with it, but I need to ask you to make a new, clean patch. Perhaps the best strategy would be to make fresh clone of today's latest code, and manually copy your Haskell changes into it, and then make a new patch from that.

If it really does just get too complicated, I'd accept a tarball, and I can manually apply the changes to my working directory and attribute the commit info to you.

01/27/2008 08:48:48 AM changed by tux_rocker

Strange. I applied those patches myself on one system, and it worked without a hitch. I'm going to look into it now.

01/27/2008 09:11:03 AM changed by tux_rocker

When manually editing a fresh checkout to include Haskell support, I get:

ohcount$ git add test/expected_dir/haskell1.hs/
The following paths are ignored by one of your .gitignore files:
test/expected_dir/haskell1.hs/ (directory)
Use -f if you really want to add them.

01/27/2008 09:26:30 AM changed by tux_rocker

  • attachment 0001-Haskell-support-take-two.patch added.

New patch against a fresh checkout

01/28/2008 11:37:33 AM changed by robin@ohloh.net

  • status changed from new to closed.
  • resolution set to fixed.

Hi tux,

I have no idea what the .gitignore problem might have been.

I was successfully able to to apply the new patch, and everything seems to be looking good.

I've pushed this patch to the Ohcount main line.

We're a bit backed up on Ohloh today (we had some server troubles over the weekend), so I'll plan to push this change to the Ohloh web site and start recounting the Haskell applications tomorrow (Tuesday).

Thanks!

05/30/2008 06:29:44 AM changed by airforce1

08/12/2008 07:47:02 AM changed by add

http://www.salewroughtiron.cn installing metal stair rails Interior stair handrail installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails http://www.china-made-door.com.cn door gate http://www.beijing-door.cn wrought CONTEMPORARY designs stairways installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails http://www.hebei-railings.cn aluminum modern log banister DECK outdoor price installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails posts vinyl curved rails

(follow-up: ↓ 14 ) 09/11/2008 11:22:40 PM changed by add

china tour Apparel shoes bags Kitchen Food and Wine Furniture) Flowers and Gifts Wall Art Computer Components

I still prefer a wiki like approach since the php (or mysql) docs are very cluttered when you have to take their comments in account. On the other hand they are professionally maintained imho, since they are *much* better than KDE documentation. KDE is by far larger and has so many different apps, which need screenshots and end user not dev/api docs, that more help is needed as long as the devs prefer to code than to write nice docs. And it is their choice to some degree imo. Technically interested but non-dev end users, which are plenty out there, are the users of and the best contributers to the docs, since they know what to write about. And they are certainly more than devs

10/07/2008 07:15:14 PM changed by add

10/07/2008 07:15:19 PM changed by add

11/11/2008 10:53:49 PM changed by storney

have no idea what the .gitignore problem might have been.

I was successfully able to to apply the new patch, and everything seems to be looking good.

I've pushed this patch to the Ohcount main line.

We're a bit backed up on Ohloh today (we had some server troubles over the weekend), so I'll plan to push this change to the Ohloh web site and start recounting the Haskell applications tomorrow (Tuesday). ShoesnikeshopWholesaleTrainersSneakers wholesalerSell Salestill prefer a wiki like approach since the php (or mysql) docs are very cluttered when you have to take their comments in account. On the other hand they are professionally maintained imho, since they are *much* better than KDE documentation. KDE is by far larger and has so many different apps, which need screenshots and end user not dev/api docs, that more help is needed as long as the devs prefer to code than to write nice docs. And it is their choice to some degree imo. Technically interested but non-dev end users, which are plenty out there, are the users of and the best contributers to the docs, since they know what to write about. And they are certainly more than devs

12/25/2008 07:55:47 PM changed by solar

Changzhou Sunpower Solar Water Heater Co., Ltd is a private company, professional producing solar water heater, and having the most advanced production line in Chinese, like automatic foaming machine imported from Italy, automatic argon arc welding machine from America, and numerical control punch. We use Germany Bayer's polyurethane and SUS304 stainless steel from Korea and Taiwan. Our company is one of the earliest companies engaging in exporting, having many years experience in exporting, and 90% of our products are exported to overseas market.

Sunpower Solar Energy Industry Co., Ltd, covers an area of nearly 150000 square metre, Now it has more than 300 workers and staff members among which the primary. Medium and high grade technicians share 65% of the total personnel. It is of abumdant technical force, advanced craft testing means. Its annual productive capacity reaches to 300000 sets. Our factory is the first to pass the ISO9001: 2000 quality system attestation among the same trade. Our products have get EN12975: 2 certificate, and all of the products are strictly complied with its standard. The goods reach to the first-class international standard. Now already export 62 counties. Our gain is "Where is sunlight, where is Sunpower". OEM also welcome.

http://www.solar-water-heaters.com.cn

04/26/2009 08:49:41 AM changed by jimbob

(in reply to: ↑ 8 ) 04/26/2009 08:52:42 AM changed by jimbob

Replying to add:

china tour Apparel shoes bags Kitchen Food and Wine Furniture) Flowers and Gifts Wall Art Computer Components I still prefer a wiki like approach since the php (or mysql) docs are very cluttered when you have to take their comments in account. On the other hand they are professionally maintained imho, since they are *much* better than KDE documentation. KDE is by far larger and has so many different apps, which need screenshots and end user not dev/api docs, that more help is needed as long as the devs prefer to code than to write nice docs. And it is their choice to some degree imo. Technically interested but non-dev end users, which are plenty out there, are the users of and the best contributers to the docs, since they know what to write about. And they are certainly more than devs

property management marbella

11/18/2009 12:29:31 AM changed by satisfyman